Update Fork to contain fallback URL #3394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveverwer
approved these changes
Sep 18, 2024
Sources/App/configure.swift
Outdated
| @@ -337,6 +337,9 @@ public func configure(_ app: Application) async throws -> String { | |||
| do { // Migration 079 - Add `forked_from` to `repositories` | |||
| app.migrations.add(UpdateRepositoryAddForkedFrom()) | |||
| } | |||
| do { // Migration 080 - Set`forkded_from` to NULL because of Fork model change in Repository | |||
There was a problem hiding this comment.
Nit: forkded_from to forked_from
Sources/App/configure.swift
Outdated
| @@ -337,6 +337,9 @@ public func configure(_ app: Application) async throws -> String { | |||
| do { // Migration 079 - Add `forked_from` to `repositories` | |||
| app.migrations.add(UpdateRepositoryAddForkedFrom()) | |||
| } | |||
| do { // Migration 080 - Set`forkded_from` to NULL because of Fork model change in Repository | |||
| app.migrations.add(UpdateRepositoryAddForkedFrom2()) | |||
There was a problem hiding this comment.
Another nit: Maybe UpdateRepositoryResetForkedFrom
daveverwer
force-pushed
the
add-forked-from-fallback
branch
from
9d8e1ae
to
6052f57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
Forkenum to contain a fallback URL which we can resort to in cases where thePackagewe are referencing is deleted. More detailed information can be found in this PR.